From: Shlok Kulshreshtha <diy2903@gmail.com>
Date: Thu, 16 Jul 2026 07:12:54 GMT
Subject: Re: [PATCH] t7614: avoid hiding git's exit code in a pipe
Message-ID: <20260716071254.14953-1-diy2903@gmail.com>
In-Reply-To: <xmqq1pd4m4ea.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> All look trivially correct.

Thanks for the review.

>  * This "cat-file the commit object, and strip away the object
>    header with sed" pattern appears quite often throughout the test
>    suite.
> [...]
>    or something like that.
>
> But again, these are clearly outside the scope of this patch.

Agreed on keeping them out of this patch.  I'd like to take up the
commit_body() helper as a separate follow-up once this lands, and
convert the existing "cat-file ... | sed" call sites (including the
unnecessary backslash before the dollar sign) over to it.

Thanks,
Shlok