[PATCH v5 0/4] environment: migrate 'trust_executable_bit' and 'has_symlinks' into 'repo_config_values'
- From
Tian Yuchen <cat@malon.dev>
- Date
- Jul 15, 2026, 03:54 UTC
- Message-ID
- <20260715035501.48271-1-cat@malon.dev>
- In-Reply-To
- <20260619162105.648495-1-cat@malon.dev>
This series moves 'trust_executable_bit' and 'has_symlinks' into 'struct repo_config_values' to tie them to the specific repository instance they were read from. Eager parsing is maintained because these two flags are heavily consulted in hot paths.
Note: 'repo_config_values()' still does not support any struct repository other than the_repository due to how deeply these flags are accessed. In other words, this series of patches is laying the groundwork for the eventual elimination of the_repository.
Previous related work:
[PATCH 2/6] config: add trust_executable_bit to global config [1] [PATCH] Refactor 'trust_executable_bit' to repository-scoped setting [2] (This previous attempt was unsuccessful because the target location selected was 'struct repo_settings', which our analysis indicated was not the optimal choice. For further details, please see: [3])
[PATCH 5/6] config: move has_symlinks [4]
RFC:
- I wonder if there is a better way to deal with compat/mingw.c in commit 4/4. Is it possible not to introduce a fallback variable?
Change since V4:
- the migration of has_symlinks is back [5], as a commit 4/4;
- drop the comment for repo_executable_bit();
- do not always pass the_repository to the getters. Use 'repo' when possible.
Thanks!
[1] https://lore.kernel.org/git/837b5360b40f992351f489a0ae05fedf49884c6e.1685716420.git.gitgitgadget@gmail.com/ [2] https://lore.kernel.org/git/20260301190017.53539-1-dronarajgyawali@gmail.com/ [3] https://lore.kernel.org/git/xmqq1pht6nyx.fsf@gitster.g/ [4] https://lore.kernel.org/git/a154008619790f7a60f2bba91db7b0fe29e67e1a.1685716420.git.gitgitgadget@gmail.com/ [5] https://lore.kernel.org/git/xmqq7bokebct.fsf@gitster.g/
Tian Yuchen (4): read-cache: remove redundant extern declarations read-cache: move 'ce_mode_from_stat()' to 'read-cache.c' environment: move trust_executable_bit into repo_config_values environment: move has_symlinks into repo_config_values
apply.c | 4 ++-- combine-diff.c | 2 +- compat/mingw.c | 7 ++++--- entry.c | 2 +- environment.c | 28 ++++++++++++++++++++++++---- environment.h | 9 +++++++-- read-cache.c | 33 ++++++++++++++++++++++++++------- read-cache.h | 16 ++-------------- 8 files changed, 67 insertions(+), 34 deletions(-)
-- 2.43.0