[PATCH v3 0/3] environment: migrate 'trust_executable_bit' into 'repo_config_values'
- From
Tian Yuchen <cat@malon.dev>
- Date
- Jun 12, 2026, 16:05 UTC
- Message-ID
- <20260612160527.167203-1-cat@malon.dev>
- In-Reply-To
- <20260610093635.139719-1-cat@malon.dev>
The 'core.filemode' (stored as 'trust_executable_bit') configuration act as a core filesystem capability flag.
This series moves it into 'struct repo_config_values' to tie it to the specific repository instance it was read from. Eager parsing is maintained because this flag is heavily consulted in hot paths.
Note: 'repo_config_values()' still does not support any struct repository other than the_repository due to how deeply these flags are accessed. In other words, this series of patches is laying the groundwork for the eventual elimination of the_repository.
Previous related work: [PATCH 2/6] config: add trust_executable_bit to global config [1] [PATCH] Refactor 'trust_executable_bit' to repository-scoped setting [2] (This previous attempt was unsuccessful because the target location selected was 'struct repo_settings', which our analysis indicated was not the optimal choice. For further details, please see: [3])
Changes since V2:
Fixed a whole bunch of typos;
Moved the comment for 'ce_mode_from_stat()' from 'read-cache.c' to 'read-cache.h'.
Thanks!
[1] https://lore.kernel.org/git/837b5360b40f992351f489a0ae05fedf49884c6e.1685716420.git.gitgitgadget@gmail.com/ [2] https://lore.kernel.org/git/20260301190017.53539-1-dronarajgyawali@gmail.com/ [3] https://lore.kernel.org/git/xmqq1pht6nyx.fsf@gitster.g/
Mentored-by: Christian Couder <christian.couder@gmail.com> Mentored-by: Ayush Chandekar <ayu.chandekar@gmail.com> Mentored-by: Olamide Caleb Bello <belkid98@gmail.com> Signed-off-by: Tian Yuchen <cat@malon.dev>
Tian Yuchen (3): read-cache: remove redundant extern declarations read-cache: move 'ce_mode_from_stat()' to 'read-cache.c' environment: move trust_executable_bit into repo_config_values
apply.c | 2 +- environment.c | 11 +++++++++-- environment.h | 9 ++++++++- read-cache.c | 21 ++++++++++++++++----- read-cache.h | 23 +++++++++-------------- 5 files changed, 43 insertions(+), 23 deletions(-)
-- 2.43.0