Re: [PATCH v3 2/2] fetch: add fetch.submoduleErrors to make submodule fetch errors non-fatal

From: Paulius Zaleckas <paulius.zaleckas@gmail.com>
Date: Jul 14, 2026, 13:29 UTC
Message-ID: <20260714132939.3368732-1-paulius.zaleckas@gmail.com>
In-Reply-To: <xmqqmrvybi5t.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> Don't we want to pass down not just
> --submodule-error=warn but --submodule-error=fail if that is what
> was given from the command line?  Or does it not matter because fail
> is the default?

Good catch, it does matter: the per-remote children of "fetch --all" re-read the repository configuration, so a configured warn silently won over an explicit --submodule-errors=fail.

Fixed in v4 by forwarding the resolved value whenever it was set explicitly, in either direction; when nothing is set, nothing is forwarded. Added a test.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.