From: Paulius Zaleckas <paulius.zaleckas@gmail.com>
Date: Tue, 14 Jul 2026 13:29:39 GMT
Subject: Re: [PATCH v3 2/2] fetch: add fetch.submoduleErrors to make submodule fetch errors non-fatal
Message-ID: <20260714132939.3368732-1-paulius.zaleckas@gmail.com>
In-Reply-To: <xmqqmrvybi5t.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> Don't we want to pass down not just
> --submodule-error=warn but --submodule-error=fail if that is what
> was given from the command line?  Or does it not matter because fail
> is the default?

Good catch, it does matter: the per-remote children of "fetch --all"
re-read the repository configuration, so a configured warn silently
won over an explicit --submodule-errors=fail.

Fixed in v4 by forwarding the resolved value whenever it was set
explicitly, in either direction; when nothing is set, nothing is
forwarded.  Added a test.

Thanks.