[PATCH v3 0/9] odb: introduce object filters to `odb_for_each_object()`
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Jul 13, 2026, 14:41 UTC
- Message-ID
- <20260713-pks-odb-for-each-object-filter-v3-0-b3c65c641073@pks.im>
- In-Reply-To
- <20260709-pks-odb-for-each-object-filter-v1-0-82fe014b12b3@pks.im>
Hi,
this patch series introduces object filters to `odb_for_each_object()`. The intent of this is to make `git cat-file --batch-all-objects` work with pluggable object databases. Right now it doesn't because it reaches into internals of the "packed" backend to efficiently handle bitmapped objects.
The series is built on top of f85a7e6620 (Start Git 2.56 cycle, 2026-07-06) with ps/odb-drop-whence at 8a7ad23e11 (odb: document object info fields, 2026-07-02) merged into it.
Changes in v3: - Weave Peff's patch into the patch series. - Link to v2: https://patch.msgid.link/20260710-pks-odb-for-each-object-filter-v2-0-3710a9cc165a@pks.im
Changes in v2:
- Add another patch to drop the `_1()` prefixes that aren't required
anymore.
- Change the approach in `open_bitmap_for_source()` to also use a
`found` boolean instead of a confusing integer.
- Add some more explanations to commit messages.
- Link to v1: https://patch.msgid.link/20260709-pks-odb-for-each-object-filter-v1-0-82fe014b12b3@pks.imThanks!
Patrick
---
Jeff King (1):
pack-objects: drop unused return value from add_object_entry()Patrick Steinhardt (8):
odb/source-packed: improve lookup when enumerating objects
pack-bitmap: mark object filter as `const`
pack-bitmap: allow aborting iteration of bitmapped objects
pack-bitmap: iterate object sources when opening bitmaps
pack-bitmap: drop `_1` suffix from functions that open bitmaps
pack-bitmap: introduce function to open bitmap for a single source
odb: introduce object filters to `odb_for_each_object()`
builtin/cat-file: filter objects via object databasebuiltin/cat-file.c | 76 +++-------------------------- builtin/pack-objects.c | 11 ++--- builtin/rev-list.c | 2 +- odb.h | 12 +++++ odb/source-packed.c | 77 ++++++++++++++++++++++++++--- pack-bitmap.c | 129 +++++++++++++++++++++++++++---------------------- pack-bitmap.h | 10 +++- 7 files changed, 175 insertions(+), 142 deletions(-)
Range-diff versus v2:
1: baf2adb012 = 1: 7c0dc1be0d odb/source-packed: improve lookup when enumerating objects 2: 57eecf3031 = 2: 2e5908c9c3 pack-bitmap: mark object filter as `const` -: ---------- > 3: f4d66ccfc6 pack-objects: drop unused return value from add_object_entry() 3: 92dd6a6f6e = 4: af475654b8 pack-bitmap: allow aborting iteration of bitmapped objects 4: 92fe41577d = 5: 6ca42587c9 pack-bitmap: iterate object sources when opening bitmaps 5: e5d59959e3 = 6: f62c3bbc81 pack-bitmap: drop `_1` suffix from functions that open bitmaps 6: ab3547ac2b = 7: b2d25b6e9b pack-bitmap: introduce function to open bitmap for a single source 7: 026f21f522 = 8: a5bf309bec odb: introduce object filters to `odb_for_each_object()` 8: 534b25c817 = 9: 600b15a907 builtin/cat-file: filter objects via object database
--- base-commit: 3c8e2790f2ce15e8b5d4b4e6ced711b12649f32a change-id: 20260708-pks-odb-for-each-object-filter-13286fa3523d