[PATCH v2 2/8] pack-bitmap: mark object filter as `const`
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Jul 10, 2026, 08:48 UTC
- Message-ID
- <20260710-pks-odb-for-each-object-filter-v2-2-3710a9cc165a@pks.im>
- In-Reply-To
- <20260710-pks-odb-for-each-object-filter-v2-0-3710a9cc165a@pks.im>
The function `for_each_bitmapped_object()` accepts an optional object filter. This filter is never modified by the function, but is not declared as `const`. Fix this.
Signed-off-by: Patrick Steinhardt <ps@pks.im> --- pack-bitmap.c | 6 +++--- pack-bitmap.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/pack-bitmap.c b/pack-bitmap.c index 35774b6f0c..a47c231632 100644 --- a/pack-bitmap.c +++ b/pack-bitmap.c @@ -1976,7 +1976,7 @@ static void filter_bitmap_object_type(struct bitmap_index *bitmap_git, static int filter_bitmap(struct bitmap_index *bitmap_git, struct object_list *tip_objects, struct bitmap *to_filter, - struct list_objects_filter_options *filter) + const struct list_objects_filter_options *filter) { if (!filter || filter->choice == LOFC_DISABLED) return 0; @@ -2027,7 +2027,7 @@ static int filter_bitmap(struct bitmap_index *bitmap_git, return -1; } -static int can_filter_bitmap(struct list_objects_filter_options *filter) +static int can_filter_bitmap(const struct list_objects_filter_options *filter) { return !filter_bitmap(NULL, NULL, NULL, filter); } @@ -2058,7 +2058,7 @@ static void filter_packed_objects_from_bitmap(struct bitmap_index *bitmap_git, } int for_each_bitmapped_object(struct bitmap_index *bitmap_git, - struct list_objects_filter_options *filter, + const struct list_objects_filter_options *filter, show_reachable_fn show_reach, void *payload) { diff --git a/pack-bitmap.h b/pack-bitmap.h index 19a8655457..47935eb24e 100644 --- a/pack-bitmap.h +++ b/pack-bitmap.h @@ -96,7 +96,7 @@ struct list_objects_filter_options; * not supported, `0` otherwise. */ int for_each_bitmapped_object(struct bitmap_index *bitmap_git, - struct list_objects_filter_options *filter, + const struct list_objects_filter_options *filter, show_reachable_fn show_reach, void *payload);
-- 2.55.0.229.g6434b31f56.dirty