Re: [PATCH v3] describe: limit default ref iteration to tags
- From
Jeff King <peff@peff.net>
- Date
- Jun 11, 2026, 06:49 UTC
- Message-ID
- <20260611064912.GC2191159@coredump.intra.peff.net>
- In-Reply-To
- <20260610-describe-tag-ref-scope-v3-1-5aa63ab279f7@gmail.com>
On Wed, Jun 10, 2026 at 11:50:01AM -0700, Tamir Duberstein wrote:
Show 11 quoted lines
> The runtime drops from 0.03(0.01+0.01) to 0.02(0.00+0.00). In a > repository with 120,532 refs but only 330 tags, the same command went > from 171.7 ms to 9.9 ms. > > Signed-off-by: Tamir Duberstein <tamird@gmail.com> > --- > Changes in v3: > - Pack the synthetic refs to better match repositories with many refs. > - Generate update-ref input with test_seq -f. > - Shorten the commit message and report the p6100.6 result. > - Link to v2: https://patch.msgid.link/20260608-describe-tag-ref-scope-v2-1-256fd36dca32@gmail.com
Thanks, this looks fine to me. I am still puzzled that your 120k ref repo is so slow in the before case. Even bumping the perf test to 100k refs, it ~10ms on my machine. But maybe it's a combination of not being well packed, plus a slower filesystem.
At any rate, I think it is obvious that doing less work is always going to be better, so there's not much need to dig too deeply into the differences for information that is probably not that useful.
-Peff