Re: [PATCH v2] describe: limit default ref iteration to tags
- From
Jeff King <peff@peff.net>
- Date
- Jun 11, 2026, 06:41 UTC
- Message-ID
- <20260611064117.GB2191159@coredump.intra.peff.net>
- In-Reply-To
- <aika_Q0rWhcI6eXR@pks.im>
On Wed, Jun 10, 2026 at 10:08:51AM +0200, Patrick Steinhardt wrote:
Show 20 quoted lines
> > Given the discussion in earlier rounds and sibling topics, I assume the > > commit message here was AI-generated. And it's OK in the sense that it > > is describing what happened and I assume is entirely accurate. But as a > > human reader, it feels so much more verbose than what I'd expect, as it > > is full of semi-irrelevant details. Why set --warmup and --runs? Why > > bother with --command-name, which just means you have to show the > > commands separately anyway? Is the amount of RAM in the machine > > important for this test? Surely it could be if it was absurdly tiny, but > > in general, no, I would not expect it to be. > > I agree. Earlier this week I also drafted a message that was going down > this angle, but I think I didn't end up sending it to the mailing list. > Or at least I'm not able to find it anymore. > > To me the biggest problem is not the verbosity, even though it _is_ > overly verbose. The bigger problem though is the incoherence of the > story that the commit message is trying to tell where it jumps around > randomly. It almost feels like rambling to me, and that makes it > extremely hard to follow the narrative and figure out what the message > even wants to tell the reader in the first place.
Thanks, this hits directly at the point I was trying to make (I have trouble sometimes with verbosity, too!). A commit message should primarily be laying out a narrative about why we are going from the old state to the new, with supporting arguments. Sometimes you need back-story for that, sometimes not. Sometimes you need to discuss alternatives, sometimes you need specific details about the platform or versions used for testing, and so on.
Show 13 quoted lines
> I very much think that we should and even have to expect that > contributors adapt, because if we don't we will basically reinforce > whatever AI is doing right now and increase the load on reviewers even > more. > > I also think that we should reserve the right to reject a patch series > completely in case we notice that we're basically just talking to a > middleman that sits between an AI prompt and us (please note that I > don't refer to this patch series specifically, this is more of a general > statement). My assumption is that this will become more important as AI > gets established in more workflows. The number of patch series that look > sane on the surface but that are utter garbage will very likely increase > quite significantly going forward.
Yep, agreed.
-Peff