git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 0/2] run-command: stop using the_repository

From
Burak Kaan Karaçay <bkkaracay@gmail.com>
Date
Mar 12, 2026, 14:44 UTC
Message-ID
<20260312144437.626392-1-bkkaracay@gmail.com>
In-Reply-To
<20260311151923.4178655-1-bkkaracay@gmail.com>
Hi,

This patch series aims to remove the_repository dependency in 'run-command.c'.

The first patch removes the dependency in start_command() by replacing the boolean 'close_object_store' flag with a pointer to the target object store.

The second patch handles the prepare_auto_maintenance() and run_auto_maintenance() functions by passing a 'struct repository *' parameter. With no global repository dependencies left, it drops the USE_THE_REPOSITORY_VARIABLE macro from the file.

Changes in v3:
- Added the second patch at the suggestion of Patrick to fully clean up
  the file.
Changes in v2:
- Dropped the wrapper approach and rewrote the patch around the approach
  suggested by René.

Thanks for all guidance, Burak Kaan Karaçay

Burak Kaan Karaçay (2):
  run-command: wean start_command() off the_repository
  run-command: wean auto_maintenance() functions off the_repository
 builtin/am.c           |  2 +-
 builtin/commit.c       |  2 +-
 builtin/fetch.c        |  2 +-
 builtin/gc.c           | 14 +++++++++-----
 builtin/merge.c        |  2 +-
 builtin/pull.c         |  2 +-
 builtin/rebase.c       |  4 +++-
 builtin/receive-pack.c |  2 +-
 run-command.c          | 20 ++++++++++----------
 run-command.h          |  9 ++++++---
 10 files changed, 34 insertions(+), 25 deletions(-)
-- 
2.53.0
Previous: Patrick SteinhardtNext: Burak Kaan Karaçay
Message 14 of 18 in “wean start_command() off the_repository”
  1. 0/4 wean start_command() off the_repositoryBurak Kaan Karaçay, Mar 11, 2026
  2. 1/4 run-command: add repo_start_command()Burak Kaan Karaçay, Mar 11, 2026
  3. 2/4 run-command: use repo_start_command() in strict callersBurak Kaan Karaçay, Mar 11, 2026
  4. Junio C HamanoMar 11, 2026
  5. 3/4 run-command: redefine start_command() as a wrapper macroBurak Kaan Karaçay, Mar 11, 2026
  6. 4/4 cocci: convert start_command() to repo_start_command()Burak Kaan Karaçay, Mar 11, 2026
  7. René ScharfeMar 11, 2026
  8. Jeff KingMar 11, 2026
  9. Burak Kaan KaraçayMar 11, 2026
  10. Junio C HamanoMar 11, 2026
  11. Junio C HamanoMar 11, 2026
  12. run-command: wean start_command() off the_repositoryBurak Kaan Karaçay, Mar 12, 2026
  13. Patrick SteinhardtMar 12, 2026
  14. 0/2 run-command: stop using the_repositoryBurak Kaan Karaçay, Mar 12, 2026
  15. 1/2 run-command: wean start_command() off the_repositoryBurak Kaan Karaçay, Mar 12, 2026
  16. 2/2 run-command: wean auto_maintenance() functions off the_repositoryBurak Kaan Karaçay, Mar 12, 2026
  17. Junio C HamanoMar 12, 2026
  18. Patrick SteinhardtMar 13, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.