Re: [PATCH 0/4] wean start_command() off the_repository

From: René Scharfe <l.s.r@web.de>
Date: Mar 11, 2026, 18:18 UTC
Message-ID: <041604ef-0bdb-4c40-a9e1-60c38ae664cb@web.de>
In-Reply-To: <20260311151923.4178655-1-bkkaracay@gmail.com>

On 3/11/26 4:19 PM, Burak Kaan Karaçay wrote:

Show 6 quoted lines

> 
> start_command() relies on the_repository due to the 'close_object_store'
> flag in 'struct child_process'. Introduce repo_start_command() to allow
> working with arbitrary repositories. Turn start_command() into a macro
> that wraps repo_start_command() and migrate the existing callers with a
> cocci script.

Good idea to expose this hidden dependency. It's different from the other repo_* functions, though, in that most callers can safely pass NULL as repo because they don't set close_object_store.

Only gc, pull and auto-maintenance set close_object_store. If we changed them to set a pointer to the object store they want to have closed instead of a binary flag then we could leave the other callers unchanged.

René