git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/7] ci: handle failures of test-slice helper

From
Patrick Steinhardt <ps@pks.im>
Date
Feb 11, 2026, 10:34 UTC
Message-ID
<20260211-b4-pks-ci-meson-improvements-v1-1-cb167cc80b86@pks.im>
In-Reply-To
<20260211-b4-pks-ci-meson-improvements-v1-0-cb167cc80b86@pks.im>

The "run-test-slice.sh" script executes the test helper to slice up tests passed to it. As the execution is part of a pipe though, we end up ignoring any potential error code returned by the helper.

Make the code more robust by storing the tests in a variable first so that we can split up the pipeline.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
---
 ci/run-test-slice.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/ci/run-test-slice.sh b/ci/run-test-slice.sh
index 0444c79c02..ff948e397f 100755
--- a/ci/run-test-slice.sh
+++ b/ci/run-test-slice.sh
@@ -5,9 +5,9 @@
 
 . ${0%/*}/lib.sh
 
-group "Run tests" make --quiet -C t T="$(cd t &&
-	./helper/test-tool path-utils slice-tests "$1" "$2" t[0-9]*.sh |
-	tr '\n' ' ')" ||
+TESTS=$(cd t && ./helper/test-tool path-utils slice-tests "$1" "$2" t[0-9]*.sh)
+
+group "Run tests" make --quiet -C t T="$(echo "$TESTS" | tr '\n' ' ')" ||
 handle_failed_tests
 
 # We only have one unit test at the moment, so run it in the first slice
-- 
2.53.0.295.g64333814d3.dirty
Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 2 of 12 in “Some assorted fixes for GitLab CI”
  1. 0/7 Some assorted fixes for GitLab CIPatrick Steinhardt, Feb 11, 2026
  2. 1/7 ci: handle failures of test-slice helperPatrick Steinhardt, Feb 11, 2026
  3. 2/7 ci: don't skip smallest test slice in GitLabPatrick Steinhardt, Feb 11, 2026
  4. 3/7 meson: fix MERGE_TOOL_DIR with "--no-bin-wrappers"Patrick Steinhardt, Feb 11, 2026
  5. 4/7 github: fix Meson tests not executing at allPatrick Steinhardt, Feb 11, 2026
  6. 5/7 ci: make test slicing consistent across Meson/MakePatrick Steinhardt, Feb 11, 2026
  7. Johannes SchindelinFeb 18, 2026
  8. Patrick SteinhardtFeb 19, 2026
  9. 6/7 gitlab-ci: use "run-test-slice-meson.sh"Patrick Steinhardt, Feb 11, 2026
  10. 7/7 gitlab-ci: handle failed tests on MSVC+Meson jobPatrick Steinhardt, Feb 11, 2026
  11. Patrick SteinhardtFeb 11, 2026
  12. Junio C HamanoFeb 11, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.