git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/7] Some assorted fixes for GitLab CI

From
Patrick Steinhardt <ps@pks.im>
Date
Feb 11, 2026, 10:34 UTC
Message-ID
<20260211-b4-pks-ci-meson-improvements-v1-0-cb167cc80b86@pks.im>
Hi,

I recently had the pleasure of debugging a couple of failing MSVC+Windows jobs in GitLab CI, which hasn't been quite fun because we didn't know to print error logs, and neither did we upload the failed test artifacts. This patch series is the result of this frustration and fixes a couple of smaller issues in the context of our CI:

  - I noticed that test slicing is slightly wrong because of a
    difference between zero- and one-based indices, which causes us to
    skip the first test on GitLab.
  - I deduplicated how we run Meson tests so that both GitLab and GitHub
    use the same "run-test-slice-meson.sh" script.
  - I add logic to handle failing tests via "print-test-failures.sh".

The result can be found at [1]. Note that tests are failing, but those failures are fixed in a separate patch series via [2]. In any case, I guess those test failures also serve as a good demonstration how the failing tests show up now.

Changes in v2:
  - Fix syntax in GitHub workflow.
  - Add another patch on top that fixes win+Meson tests in GitHub. Those
    tests didn't execute at all, even before this patch series.
  - This uncovers another bug in how we set up MERGE_TOOLS_DIR, so this
    results in another commit.
  - I've now tested also tested the changes on GitHub [3].
  - Link to v1: https://lore.kernel.org/r/20260209-b4-pks-ci-msvc-iconv-fixes-v1-0-1e3167cd8828@pks.im
Thanks!
Patrick

[1]: https://gitlab.com/gitlab-org/git/-/merge_requests/497 [2]: <20260209-b4-pks-ci-msvc-iconv-fixes-v1-0-1e3167cd8828@pks.im> [3]: https://github.com/git/git/pull/2195

---
Patrick Steinhardt (7):
      ci: handle failures of test-slice helper
      ci: don't skip smallest test slice in GitLab
      meson: fix MERGE_TOOL_DIR with "--no-bin-wrappers"
      github: fix Meson tests not executing at all
      ci: make test slicing consistent across Meson/Make
      gitlab-ci: use "run-test-slice-meson.sh"
      gitlab-ci: handle failed tests on MSVC+Meson job
 .github/workflows/main.yml |  6 +++---
 .gitlab-ci.yml             | 17 +++++++++++++++--
 ci/run-test-slice-meson.sh |  2 +-
 ci/run-test-slice.sh       |  6 +++---
 t/helper/test-path-utils.c | 18 ++++++++++++------
 t/meson.build              |  1 +
 6 files changed, 35 insertions(+), 15 deletions(-)

--- base-commit: 3e0db84c88c57e70ac8be8c196dfa92c5d656fbc change-id: 20260209-b4-pks-ci-meson-improvements-93d8a1ffdd27

Next: Patrick Steinhardt
Message 1 of 12 in “Some assorted fixes for GitLab CI”
  1. 0/7 Some assorted fixes for GitLab CIPatrick Steinhardt, Feb 11, 2026
  2. 1/7 ci: handle failures of test-slice helperPatrick Steinhardt, Feb 11, 2026
  3. 2/7 ci: don't skip smallest test slice in GitLabPatrick Steinhardt, Feb 11, 2026
  4. 3/7 meson: fix MERGE_TOOL_DIR with "--no-bin-wrappers"Patrick Steinhardt, Feb 11, 2026
  5. 4/7 github: fix Meson tests not executing at allPatrick Steinhardt, Feb 11, 2026
  6. 5/7 ci: make test slicing consistent across Meson/MakePatrick Steinhardt, Feb 11, 2026
  7. Johannes SchindelinFeb 18, 2026
  8. Patrick SteinhardtFeb 19, 2026
  9. 6/7 gitlab-ci: use "run-test-slice-meson.sh"Patrick Steinhardt, Feb 11, 2026
  10. 7/7 gitlab-ci: handle failed tests on MSVC+Meson jobPatrick Steinhardt, Feb 11, 2026
  11. Patrick SteinhardtFeb 11, 2026
  12. Junio C HamanoFeb 11, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.