Re: [PATCH v5] lockfile: add PID file for debugging stale locks
- From
Jeff King <peff@peff.net>
- Date
- Jan 21, 2026, 19:53 UTC
- Message-ID
- <20260121195329.GA584009@coredump.intra.peff.net>
- In-Reply-To
- <xmqqcy32u769.fsf@gitster.g>
On Wed, Jan 21, 2026 at 10:55:42AM -0800, Junio C Hamano wrote:
Show 8 quoted lines
> Jeff King <peff@peff.net> writes: > > > The second half is still valid, I think, but at that point it is the > > only path that uses the close() in the out-path, so we might as well > > drop the out-path one. > > True. A fix-up may look like this. I've got rid of the assignments > to "fd" that are not used.
Yup, that all looks correct to me.
-Peff