From: Jeff King Date: Wed, 21 Jan 2026 19:53:29 GMT Subject: Re: [PATCH v5] lockfile: add PID file for debugging stale locks Message-ID: <20260121195329.GA584009@coredump.intra.peff.net> In-Reply-To: On Wed, Jan 21, 2026 at 10:55:42AM -0800, Junio C Hamano wrote: > Jeff King writes: > > > The second half is still valid, I think, but at that point it is the > > only path that uses the close() in the out-path, so we might as well > > drop the out-path one. > > True. A fix-up may look like this. I've got rid of the assignments > to "fd" that are not used. Yup, that all looks correct to me. -Peff