git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] test-suite fixes for upcoming curl 8.18.0

From
Jeff King <peff@peff.net>
Date
Dec 19, 2025, 23:23 UTC
Message-ID
<20251219232357.GA3960837@coredump.intra.peff.net>
In-Reply-To
<0s72r344-865q-2n3q-o9q9-p701087s0n04@unkk.fr>
On Fri, Dec 19, 2025 at 09:47:37AM +0100, Daniel Stenberg wrote:
Show 10 quoted lines
> On Fri, 19 Dec 2025, Jeff King wrote:
> 
> > > [1] = https://github.com/curl/curl/commit/9941e7c95bf26f00fd87888a
> > 
> > and it fixes the first of Git's failing tests. But if we swap out the
> > space for a tab like this:
> 
> Sorry, that was just sloppy of me to not add a test and proper handling for
> that condition. Allow me to fix that in my end. A leading tab in the folding
> part should be replaced by a space.

Thanks! I ran Git's test suite against a build using your 6c7bc9871f (http: fix for unfolding line starting with TAB, 2025-12-19) and it works without the whitespace-relaxing in my third patch.

I also double-checked against the current tip of curl's master, which includes 3388afd2b6 (http: more unfold fixing, 2025-12-19), and everything remains fine. Thanks for a prompt fix.

Junio: I think we could just drop the third patch here, if we don't mind
test failures against an unreleased version of curl. It's in debian
unstable now, but presumably they'll move to the released 8.18.0 once
it's out.
-Peff
Previous: Daniel StenbergNext: Junio C Hamano
Message 12 of 14 in “test-suite fixes for upcoming curl 8.18.0”
  1. 0/3 test-suite fixes for upcoming curl 8.18.0Jeff King, Dec 18, 2025
  2. 1/3 t5551: handle trailing slashes in expected cookies outputJeff King, Dec 18, 2025
  3. 2/3 t5563: add missing end-of-line in HTTP headerJeff King, Dec 18, 2025
  4. Matthew John CheethamDec 18, 2025
  5. Jeff KingDec 19, 2025
  6. 3/3 t5563: relax whitespace assumptions for unfolded headersJeff King, Dec 18, 2025
  7. Matthew John CheethamDec 18, 2025
  8. Daniel StenbergDec 18, 2025
  9. Daniel StenbergDec 18, 2025
  10. Jeff KingDec 19, 2025
  11. Daniel StenbergDec 19, 2025
  12. Jeff KingDec 19, 2025
  13. Junio C HamanoDec 20, 2025
  14. Jeff KingDec 19, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.