Re: [PATCH 2/3] t5563: add missing end-of-line in HTTP header
- From
Jeff King <peff@peff.net>
- Date
- Dec 19, 2025, 07:32 UTC
- Message-ID
- <20251219073232.GA3784564@coredump.intra.peff.net>
- In-Reply-To
- <FRWPR03MB110658677899817CC49A50DE7C0A8A@FRWPR03MB11065.eurprd03.prod.outlook.com>
On Thu, Dec 18, 2025 at 01:41:54PM +0000, Matthew John Cheetham wrote:
Show 19 quoted lines
> On 2025-12-18 12:18, Jeff King wrote: > > > In t5563, we test how various oddly-formatted WWW-Authenticate headers > > are passed through curl to git's credential subsystem (and ultimately > > out to credential helpers). One test, "access using basic auth with > > wwwauth header mixed line-endings" does something odd. It does not mix > > line endings at all (which must be CRLF according to the RFC anyway), > > but omits the line ending entirely for the final header! > > Aha! Yes, the test should be using *all CRLF line endings*, and is > poorly named. I believe the intent here is to test mixed *continuation > line* characters. > > E.g, when a continuation line starts with a space, or a tab character, > for the same logical header: > > WWW-Authenticate: FooBar param1="value1"\r\n > \r\n > \tparam2="value2"\r\n
Ah, great. I'm happy that my guess was right and there was not something trickier going on (which would have made coming up with a workaround more difficult!). Thanks for confirming.
-Peff