git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] [PATCH] [Outreachy]: remove outdated NEEDSWORK comment

From
OAOkhuomon Ajayi <okhuomonajayi54@gmail.com>
Date
Oct 13, 2025, 18:02 UTC
Message-ID
<20251013180217.248177-1-okhuomonajayi54@gmail.com>

The NEEDSWORK comment about const correctness is no longer needed. The hashmap API mandates that cmpfn_data is const, and casting to opt (non-const) is the only reasonable approach. No functional change is required, and this commit clarifies the code for future readers.

Signed-off-by: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
---
 patch-ids.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/patch-ids.c b/patch-ids.c
index b6b808332f..24309913b9 100644
--- a/patch-ids.c
+++ b/patch-ids.c
@@ -42,7 +42,7 @@ static int patch_id_neq(const void *cmpfn_data,
 			const void *keydata UNUSED)
 {
 	
-	const struct diff_options *opt = (void *)cmpfn_data;
+        struct diff_options *opt = (void *)cmpfn_data;
 	struct patch_id *a, *b;
 
 	a = container_of(eptr, struct patch_id, ent);
-- 
2.43.0
Message 1 of 1 in “[Outreachy]: remove outdated NEEDSWORK comment”
  1. [PATCH] [Outreachy]: remove outdated NEEDSWORK commentOkhuomon Ajayi, Oct 13, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.