threads / patch / 64310

patch[Outreachy]: remove outdated NEEDSWORK comment

Subject: [PATCH] [PATCH] [Outreachy]: remove outdated NEEDSWORK comment

## tl;dr

One message between Oct 13, 2025 and Oct 13, 2025. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Okhuomon Ajayi· Oct 13, 2025, 18:02 UTC · lore

The NEEDSWORK comment about const correctness is no longer needed. The hashmap API mandates that cmpfn_data is const, and casting to opt (non-const) is the only reasonable approach. No functional change is required, and this commit clarifies the code for future readers.

Signed-off-by: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
---
 patch-ids.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to patch-ids.c +1 −1
diff --git a/patch-ids.c b/patch-ids.c
index b6b808332f..24309913b9 100644
--- a/patch-ids.c
+++ b/patch-ids.c
@@ -42,7 +42,7 @@ static int patch_id_neq(const void *cmpfn_data,
 			const void *keydata UNUSED)
 {
 	
-	const struct diff_options *opt = (void *)cmpfn_data;
+        struct diff_options *opt = (void *)cmpfn_data;
 	struct patch_id *a, *b;
 
 	a = container_of(eptr, struct patch_id, ent);
-- 
2.43.0

← back to recent threads