Re: [PATCH 1/6] stash: tell setup_revisions() to free our allocated strings

From: Jeff King <peff@peff.net>
Date: Sep 23, 2025, 00:48 UTC
Message-ID: <20250923004808.GA2271307@coredump.intra.peff.net>
In-Reply-To: <xmqqms6mrxez.fsf@gitster.g>

On Mon, Sep 22, 2025 at 02:26:44PM -0700, Junio C Hamano wrote:

> By the way this also solves the original "git stash show -p --invalid";
> do we want to credit the bug reporter and mention that issue as well?

That's not handled by this patch, but rather by patch 2 ("manage memory ownership..."). I put this one first because until we start setting the free_removed_argv_elements flag, that second patch won't do anything for git-stash (and I don't think there was a way to trigger the problems from the other callers which did set it).

That patch discusses the original issue, but yeah, it could probably stand to have a:

  Reported-by: Lauri Niskanen <ape@ape3000.com>

trailer tacked on.

-Peff