Re: [PATCH 3/6] revision: add wrapper to setup_revisions() from a strvec

From: Jeff King <peff@peff.net>
Date: Sep 20, 2025, 05:48 UTC
Message-ID: <20250920054828.GA996396@coredump.intra.peff.net>
In-Reply-To: <CAPig+cRSQAs79oVmNqvfqhEr6K3T1FR13NwbE50A5CCMJ8RqSA@mail.gmail.com>

On Sat, Sep 20, 2025 at 01:10:50AM -0400, Eric Sunshine wrote:

Show 13 quoted lines

> On Fri, Sep 19, 2025 at 6:51 PM Jeff King <peff@peff.net> wrote:
> > The setup_revisions() function was designed to take the argc/argv pair
> > from the operating system. But we sometimes construct our own argv using
> > a strvec and pass that in. There are a few gotchas that callers need to
> > deal with here:
> > [...]
> > We'll start by converting all of the call-sites which the
> > free_removed_argv_elements option. There should be no behavior change
> > for them, except that their "shrunken" entries are cleaned up
> > immediately, rather than waiting for a strvec_clear() call.
> 
> There is some grammatical problem with the first sentence of this
> paragraph which makes it difficult to decipher.

Urgh, sorry. Should be:

   We'll start by converting all of the call-sites which use the
   free_removed_argv_elements option.

-Peff