git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] t5510: make confusing config cleanup more explicit

From
Jeff King <peff@peff.net>
Date
Aug 19, 2025, 20:53 UTC
Message-ID
<20250819205338.GA1071667@coredump.intra.peff.net>
In-Reply-To
<8797c495-8277-4f65-845b-167542b82949@charter.net>
On Tue, Aug 19, 2025 at 04:03:23PM -0400, Eric Sunshine wrote:
Show 8 quoted lines
> > diff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh
> > @@ -119,7 +119,7 @@ test_expect_success "fetch test remote HEAD change" '
> > -	test_when_finished "git config unset remote.origin.followRemoteHEAD" &&
> > +	test_when_finished "git -C \"$D/two\" config unset remote.origin.followRemoteHEAD" &&
> 
> For what it's worth, I have an unsent patch from a much larger unsent series
> which cleans up the t5510 messiness differently. (The below patch is
> probably whitespace damaged by the MUA.)

See my patch 2, which does this part. I split this out because it got complicated to explain why that patch wasn't breaking these lines. ;)

-Peff
Previous: Eric SunshineNext: Jeff King
Message 6 of 22 in “dangling symrefs and fetchRemoteHEAD=create”
  1. 0/4 dangling symrefs and fetchRemoteHEAD=createJeff King, Aug 19, 2025
  2. Jeff KingAug 19, 2025
  3. 1/4 t5510: make confusing config cleanup more explicitJeff King, Aug 19, 2025
  4. Eric SunshineAug 19, 2025
  5. Eric SunshineAug 19, 2025
  6. Jeff KingAug 19, 2025
  7. 2/4 t5510: stop changing top-level working directoryJeff King, Aug 19, 2025
  8. 3/4 t5510: prefer "git -C" to subshell for followRemoteHEAD testsJeff King, Aug 19, 2025
  9. SZEDER GáborAug 24, 2025
  10. Junio C HamanoAug 25, 2025
  11. Jeff KingAug 26, 2025
  12. Junio C HamanoAug 26, 2025
  13. 4/4 refs: do not clobber dangling symrefsJeff King, Aug 19, 2025
  14. Patrick SteinhardtAug 20, 2025
  15. Jeff KingAug 20, 2025
  16. Toon ClaesSep 22, 2025
  17. Junio C HamanoSep 22, 2025
  18. Jeff KingSep 22, 2025
  19. Junio C HamanoSep 22, 2025
  20. Jeff KingSep 22, 2025
  21. Toon ClaesSep 23, 2025
  22. Jeff KingSep 23, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.