Re: [PATCH 0/4] dangling symrefs and fetchRemoteHEAD=create

From: Jeff King <peff@peff.net>
Date: Aug 19, 2025, 19:23 UTC
Message-ID: <20250819192356.GA1059166@coredump.intra.peff.net>
In-Reply-To: <20250819192004.GA1058857@coredump.intra.peff.net>

On Tue, Aug 19, 2025 at 03:20:04PM -0400, Jeff King wrote:

Show 8 quoted lines

> A fix is in the final patch, along with a detailed explanation. The
> earlier patches are just cleanup of the related test script before we
> add our new test there.
> 
>   [1/4]: t5510: make confusing config cleanup more explicit
>   [2/4]: t5510: stop changing top-level working directory
>   [3/4]: t5510: prefer "git -C" to subshell for followRemoteHEAD tests
>   [4/4]: refs: do not clobber dangling symrefs

Oh, one thing I forgot to mention: this must be applied on top of ps/reflog-migrate-fixes. Specifically the changes to check_old_oid() in 046c67325c (refs: stop unsetting REF_HAVE_OLD for log-only updates, 2025-08-06). Otherwise this logic kicks in for split-HEAD updates, which makes no sense (if we are creating "refs/heads/foo" and HEAD happens to point to that branch, we split off a reflog update of HEAD, but we should not enforce any old-oid rules since we are not writing HEAD at all).

-Peff