[PATCH 2/3] oidmap: add size function
- From
Jeff King <peff@peff.net>
- Date
- May 12, 2025, 18:51 UTC
- Message-ID
- <20250512185130.GB1276214@coredump.intra.peff.net>
- In-Reply-To
- <20250512185006.GA1275914@coredump.intra.peff.net>
Callers which want to know how many items are in an oidmap have to look at the underlying hashmap struct, leaking an implementation detail. Let's provide a type-appropriate wrapper and use it.
Note in the call from lookup_replace_object(), the caller was actually looking at the hashmap's tablesize parameter (the allocated size of the table) rather than hashmap_get_size(), the number of items in the table. This probably should have been checking the number of items all along, but the two are functionally equivalent here since we only add to the map and never remove anything. Thus if there was any allocation, it was because there is at least one item.
Signed-off-by: Jeff King <peff@peff.net> --- commit-graph.c | 2 +- oidmap.h | 4 ++++ replace-object.h | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/commit-graph.c b/commit-graph.c index 6394752b0b..1a74e1e1ba 100644 --- a/commit-graph.c +++ b/commit-graph.c @@ -222,7 +222,7 @@ static int commit_graph_compatible(struct repository *r) if (replace_refs_enabled(r)) { prepare_replace_object(r); - if (hashmap_get_size(&r->objects->replace_map->map)) + if (oidmap_get_size(r->objects->replace_map)) return 0; } diff --git a/oidmap.h b/oidmap.h index 603ae1adbc..67fb32290f 100644 --- a/oidmap.h +++ b/oidmap.h @@ -67,6 +67,10 @@ void *oidmap_put(struct oidmap *map, void *entry); */ void *oidmap_remove(struct oidmap *map, const struct object_id *key); +static inline unsigned int oidmap_get_size(struct oidmap *map) +{ + return hashmap_get_size(&map->map); +} struct oidmap_iter { struct hashmap_iter h_iter; diff --git a/replace-object.h b/replace-object.h index ba478eb30c..4226376534 100644 --- a/replace-object.h +++ b/replace-object.h @@ -47,7 +47,7 @@ static inline const struct object_id *lookup_replace_object(struct repository *r { if (!replace_refs_enabled(r) || (r->objects->replace_map_initialized && - r->objects->replace_map->map.tablesize == 0)) + oidmap_get_size(r->objects->replace_map) == 0)) return oid; return do_lookup_replace_object(r, oid); }
-- 2.49.0.821.gd3b3298025