git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[GSoC][RFC PATCH 5/6] log-tree: add subject prefix in output email subject

From
Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
Date
Mar 3, 2025, 22:00 UTC
Message-ID
<20250303220029.10716-6-lucasseikioshiro@gmail.com>
In-Reply-To
<20250303220029.10716-1-lucasseikioshiro@gmail.com>

When an extra subject prefix is provided by the user when calling `format-patch --subject-extra-prefix`, insert it between brackets at the beginning of the the patch subject. Don't change the behavior when this flag is not used.

For example, this `format-patch` call:
`git format-patch -1 --subject-extra-prefix EXTRA -n -v2`
will create a patch with the subject beginning with:
`Subject: [EXTRA][PATCH v2 1/1]`
Signed-off-by: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
---
 log-tree.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/log-tree.c b/log-tree.c
index 8b184d6776..d72ab25585 100644
--- a/log-tree.c
+++ b/log-tree.c
@@ -478,17 +478,21 @@ void fmt_output_commit(struct strbuf *filename,
 
 void fmt_output_email_subject(struct strbuf *sb, struct rev_info *opt)
 {
+	strbuf_addstr(sb, "Subject: ");
+
+	if (opt->subject_extra_prefix && *opt->subject_extra_prefix)
+		strbuf_addf(sb, "[%s]",
+			    opt->subject_extra_prefix);
+
 	if (opt->total > 0) {
-		strbuf_addf(sb, "Subject: [%s%s%0*d/%d] ",
+		strbuf_addf(sb, "[%s%s%0*d/%d] ",
 			    opt->subject_prefix,
 			    *opt->subject_prefix ? " " : "",
 			    decimal_width(opt->total),
 			    opt->nr, opt->total);
 	} else if (opt->total == 0 && opt->subject_prefix && *opt->subject_prefix) {
-		strbuf_addf(sb, "Subject: [%s] ",
+		strbuf_addf(sb, "[%s] ",
 			    opt->subject_prefix);
-	} else {
-		strbuf_addstr(sb, "Subject: ");
 	}
 }
 
-- 
2.39.5 (Apple Git-154)
Previous: Lucas Seiki OshiroNext: Lucas Seiki Oshiro
Message 7 of 15 in “Add --subject-extra-prefix flag to format-patch”
  1. Lucas Seiki OshiroMar 3, 2025
  2. [GSoC][RFC PATCH 1/6] builtin/log: add subject-extra-prefix flag to format-patchLucas Seiki Oshiro, Mar 3, 2025
  3. [GSoC][RFC PATCH 2/6] builtin/log: die if -k and --suject-extra-prefix are used togetherLucas Seiki Oshiro, Mar 3, 2025
  4. Eric SunshineMar 3, 2025
  5. [GSoC][RFC PATCH 3/6] revision: add subject_extra_field to struct rev_infoLucas Seiki Oshiro, Mar 3, 2025
  6. [GSoC][RFC PATCH 4/6] builtin/log: fill subject extra prefix in format-patchLucas Seiki Oshiro, Mar 3, 2025
  7. [GSoC][RFC PATCH 5/6] log-tree: add subject prefix in output email subjectLucas Seiki Oshiro, Mar 3, 2025
  8. [GSoC][RFC PATCH 6/6] t4014: add tests for the new flag --subject-extra-prefixLucas Seiki Oshiro, Mar 3, 2025
  9. Junio C HamanoMar 3, 2025
  10. Patrick SteinhardtMar 4, 2025
  11. Junio C HamanoMar 4, 2025
  12. Junio C HamanoMar 4, 2025
  13. Lucas Seiki OshiroMar 4, 2025
  14. Junio C HamanoMar 5, 2025
  15. Lucas Seiki OshiroMar 5, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.