Re: [GSOC][PATCH] apply: address -Wsign-comparison warnings

From: Zejun Zhao <jelly.zhao.42@gmail.com>
Date: Feb 23, 2025, 17:36 UTC
Message-ID: <20250223173629.16489-1-jelly.zhao.42@gmail.com>
In-Reply-To: <xmqq34g7cjf2.fsf@gitster.g>

Thank you for clarifying. Now I can see the concern on whether the whole bunch of things worth it; it's a trade-off between cleanness and robustness of the codebase and it's very common due to some coding conventions (e.g. error handling) in C. Maybe in this case we should just leave the working code work.

Now I'd like to ask for your advice on this issue, which I may be supposed to do before sending any actual patches, should I push forward this patchset further or pick another microproject?

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.