git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/9] prio-queue: fix type of `insertion_ctr`

From
Jeff King <peff@peff.net>
Date
Dec 27, 2024, 14:36 UTC
Message-ID
<20241227143608.GC88306@coredump.intra.peff.net>
In-Reply-To
<20241227-b4-pks-commit-reach-sign-compare-v1-1-07c59c2aa632@pks.im>
On Fri, Dec 27, 2024 at 11:46:21AM +0100, Patrick Steinhardt wrote:
Show 11 quoted lines
> In 62e745ced2 (prio-queue: use size_t rather than int for size,
> 2024-12-20), we have converted `struct prio_queue` to use `size_t` to
> track the number of entries in the queue as well as the allocated size
> of the underlying array. There is one more counter though, namely the
> insertion counter, that is still using an `unsigned` instead of a
> `size_t`. This is unlikely to ever be a problem, but it makes one wonder
> why some indices use `size_t` while others use `unsigned`. Furthermore,
> the mentioned commit stated the intent to also adapt these variables,
> but seemingly forgot to do so.
> 
> Fix the issue by converting those counters to use `size_t`, as well.
Yep, this looks good, and was what I meant to send in 62e745ced2.
-Peff
Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 3 of 34 in “commit-reach: -Wsign-compare follow-ups”
  1. 0/9 commit-reach: -Wsign-compare follow-upsPatrick Steinhardt, Dec 27, 2024
  2. 1/9 prio-queue: fix type of `insertion_ctr`Patrick Steinhardt, Dec 27, 2024
  3. Jeff KingDec 27, 2024
  4. 2/9 commit-reach: fix index used to loop through unsigned integerPatrick Steinhardt, Dec 27, 2024
  5. Jeff KingDec 27, 2024
  6. 3/9 commit-reach: fix type of `min_commit_date`Patrick Steinhardt, Dec 27, 2024
  7. 4/9 commit-reach: use `size_t` to track indices in `remove_redundant()`Patrick Steinhardt, Dec 27, 2024
  8. Justin ToblerJan 3, 2025
  9. 5/9 commit-reach: use `size_t` to track indices in `get_reachable_subset()`Patrick Steinhardt, Dec 27, 2024
  10. 6/9 builtin/log: use `size_t` to track indicesPatrick Steinhardt, Dec 27, 2024
  11. Justin ToblerJan 3, 2025
  12. Patrick SteinhardtJan 3, 2025
  13. 7/9 builtin/log: fix remaining -Wsign-compare warningsPatrick Steinhardt, Dec 27, 2024
  14. shejialuoDec 27, 2024
  15. Patrick SteinhardtDec 27, 2024
  16. shejialuoDec 27, 2024
  17. 8/9 shallow: fix -Wsign-compare warningsPatrick Steinhardt, Dec 27, 2024
  18. 9/9 commit-reach: use `size_t` to track indices when computing merge basesPatrick Steinhardt, Dec 27, 2024
  19. Justin ToblerJan 3, 2025
  20. Patrick SteinhardtJan 3, 2025
  21. Junio C HamanoDec 27, 2024
  22. Junio C HamanoDec 27, 2024
  23. Jeff KingDec 27, 2024
  24. Patrick SteinhardtDec 28, 2024
  25. Junio C HamanoDec 28, 2024
  26. Patrick SteinhardtDec 28, 2024
  27. Junio C HamanoDec 28, 2024
  28. racy leak sanitizer builds, was Re: [PATCH 0/9] commit-reach: -Wsign-compare follow-upsJeff King, Dec 28, 2024
  29. Jeff KingDec 28, 2024
  30. Jeff KingDec 28, 2024
  31. René ScharfeDec 29, 2024
  32. Jeff KingDec 29, 2024
  33. Jeff KingDec 30, 2024
  34. Junio C HamanoDec 30, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.