[PATCH 2/9] commit-reach: fix index used to loop through unsigned integer
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Dec 27, 2024, 10:46 UTC
- Message-ID
- <20241227-b4-pks-commit-reach-sign-compare-v1-2-07c59c2aa632@pks.im>
- In-Reply-To
- <20241227-b4-pks-commit-reach-sign-compare-v1-0-07c59c2aa632@pks.im>
In 62e745ced2 (prio-queue: use size_t rather than int for size, 2024-12-20), we refactored `struct prio_queue` to track the number of contained entries via a `size_t`. While the refactoring adapted one of the users of that variable, it forgot to also adapt "commit-reach.c" accordingly. This was missed because that file has -Wsign-conversion disabled.
Fix the issue by using a `size_t` to iterate through entries.
Signed-off-by: Patrick Steinhardt <ps@pks.im> --- commit-reach.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/commit-reach.c b/commit-reach.c index e3edd1199529792fafbaa03999c5b7b202f7cf1b..e65872617003d0e43776909c30343f091d6b42f2 100644 --- a/commit-reach.c +++ b/commit-reach.c @@ -42,8 +42,7 @@ static int compare_commits_by_gen(const void *_a, const void *_b) static int queue_has_nonstale(struct prio_queue *queue) { - int i; - for (i = 0; i < queue->nr; i++) { + for (size_t i = 0; i < queue->nr; i++) { struct commit *commit = queue->array[i].data; if (!(commit->object.flags & STALE)) return 1;
-- 2.48.0.rc0.184.g0fc57dec57.dirty