Re: [PATCH 6/6] hash.h: drop unsafe_ function variants

From: Jeff King <peff@peff.net>
Date: Nov 21, 2024, 09:41 UTC
Message-ID: <20241121094144.GE602681@coredump.intra.peff.net>
In-Reply-To: <4081ad08549895a1b05c45fbc6f229683fec3963.1732130001.git.me@ttaylorr.com>

On Wed, Nov 20, 2024 at 02:13:59PM -0500, Taylor Blau wrote:

Show 11 quoted lines

> Now that all callers have been converted from:
> 
>     the_hash_algo->unsafe_init_fn();
> 
> to
> 
>     unsafe_hash_algo(the_hash_algo)->unsafe_init_fn();
> 
> and similar, we can remove the scaffolding for the unsafe_ function
> variants and force callers to use the new unsafe_hash_algo() mechanic
> instead.

Nice. Especially for sha256, which does not even need to care about this unsafe thing at all (so in 2099, when we finally remove sha1 support, this whole system can go away!).

I think this also opens up alternatives for how we conditionally compile things. E.g., if you have no *_SHA1_UNSAFE macro defined, we could avoid defining sha1_unsafe_algo at all, and just leave it as NULL. I can't think of a significant enough advantage to merit the work in converting to that, though, so it's probably not worth doing unless we later decide it would make things simpler for some reason.

-Peff