Re: [PATCH v3 2/3] safe.directory: normalize the configured path

From: Jeff King <peff@peff.net>
Date: Jul 30, 2024, 20:10 UTC
Message-ID: <20240730201017.GB567852@coredump.intra.peff.net>
In-Reply-To: <xmqqv80metou.fsf@gitster.g>

On Tue, Jul 30, 2024 at 09:22:09AM -0700, Junio C Hamano wrote:

Show 8 quoted lines

> > Obviously not new in your patch, but maybe worth fixing while in the
> > area? I think it comes from an evil merge in b8bdb2f283 (Merge branch
> > 'jc/safe-directory-leading-path', 2024-06-12).
> 
> I think it deserves to be a separate change, probably a preliminary
> clean-up, as it predates that by a few years, and goes back to the
> initial introduction of the safe.directory feature.  The merge you
> found had this bit:

Ah, yeah, I was busy looking at the assignments and didn't notice the ternary in the function call. So yeah, it comes from that earlier commit, but I think it was equally useless there.

And yes, fixing it definitely should be a separate commit.

-Peff