Re: [PATCH v2 1/2] Teach git version --build-options about libcurl

From: Jeff King <peff@peff.net>
Date: Jul 24, 2024, 20:55 UTC
Message-ID: <20240724205541.GA557365@coredump.intra.peff.net>
In-Reply-To: <402c12c2-7ada-4d9e-c3da-1a78827e7496@gmx.de>

On Wed, Jul 24, 2024 at 12:48:20PM +0200, Johannes Schindelin wrote:

Show 12 quoted lines

> > But we could also have "git version --build-options" call "remote-https
> > --build-options" automatically, and just let it dump to the shared
> > stdout stream.
> 
> Teaching `git version` to show the cURL version may not be the best idea,
> especially when it comes to the version used at runtime and using the
> command-line option `--build-options` (with the option being specifically
> about the build, not the runtime, version that was used).
> 
> Wouldn't it be better to go with Emily's approach to surface this
> information via `git bugreport` instead of `git version`, potentially
> enhanced to show both build-time and runtime version of libcurl?

I don't have a strong preference either way. I naturally turned towards "git version" because that's what this thread was about, and also because it predates git-bugreport.

It feels like there may be some duplication / overlap between what those two things inspect, and we should perhaps unify them. One thing I notice about bugreport is that it doesn't have a way to just dump information without trying to start a bugreport. I'd be very unlikely to use it myself for reporting a bug, but I may want to dump information about git while debugging.

So whether that is in the form of "git bugreport --dump", or if all of the collection is moved to "git version --build-info" and then bugreport uses that to fill out its template, I don't care.

-Peff