Re: [PATCH v2 1/2] Teach git version --build-options about libcurl

From: Jeff King <peff@peff.net>
Date: Jun 24, 2024, 23:55 UTC
Message-ID: <20240624235557.GA2727@coredump.intra.peff.net>
In-Reply-To: <xmqqed8me36c.fsf@gitster.g>

On Mon, Jun 24, 2024 at 09:06:03AM -0700, Junio C Hamano wrote:

Show 10 quoted lines

> > Wouldn't calling `curl_version()` make more sense here?
> 
> I wouldn't give that question an outright "no", but unless "git
> version" is split out of the builtin suite of commands and made into
> a standalone binary, I would *not* be able to give an unconditional
> "yes".
> 
> For now, let's stop at the simplest solution---if the library
> project gives us a CPP macro to use for _this exact purpose_, let's
> take the offer.

Here's another point of view: libcurl is not a dependency of the git binary at all! It is a dependency of the "curl" remote helper. Would it make sense for "git remote-https --build-options" to exist?

I'm not sure. It resolves the linking problem and matches how the actual programs are structured. But it is also not something that normal users would tend to think about (even if you are having trouble with https remotes, you might not know that is implemented as a remote helper).

But we could also have "git version --build-options" call "remote-https --build-options" automatically, and just let it dump to the shared stdout stream.

-Peff