Re: [PATCH v2] builtin/push: call set_refspecs after validating remote

From: Jeff King <peff@peff.net>
Date: Jul 11, 2024, 21:32 UTC
Message-ID: <20240711213233.GC3648684@coredump.intra.peff.net>
In-Reply-To: <CAOLa=ZT-psS1NecoppGOVdxgn+kMqi8qx2vCLMKNXB4n+5hE0A@mail.gmail.com>

On Thu, Jul 11, 2024 at 02:35:08AM -0700, Karthik Nayak wrote:

Show 6 quoted lines

> > But all of that would be internal refactoring / cleanup on top of your
> > patch. The user-facing behavior would be the same.
> 
> These should work as intended on top of my patch. But I will skip doing
> these changes for now. I do see the merit but I think it is also okay
> the way it is now.

Yep, that is perfectly fine with me. Thanks for working on this!

-Peff