Re: [PATCH] builtin/push: call set_refspecs after validating remote

From: Jeff King <peff@peff.net>
Date: Jul 8, 2024, 23:33 UTC
Message-ID: <20240708233350.GA948906@coredump.intra.peff.net>
In-Reply-To: <xmqqsewjelrh.fsf@gitster.g>

On Mon, Jul 08, 2024 at 12:17:38PM -0700, Junio C Hamano wrote:

Show 10 quoted lines

> > This worked earlier since we would get a remote, albeit with an
> > empty URL. With the new changes, we get a NULL remote and this crashes.
> 
> You'd really really need to clarify what you mean by "a NULL remote"
> if you want the proposed log message and the change to be
> understood.  The change made by 9badf97c (remote: allow resetting
> url list, 2024-06-14), as far as I can tell, can make the strvecs
> that hold URL and pushURL in a remote structure empty, but it does
> not otherwise destroy the remote structure, or nullify a pointer
> that points at the remote structure.  So I am completely lost here.

I was somewhat confused how it could happen, too. ;) I left more comments elsewhere in the thread, but the gist of it is that an empty remote name confuses the "when there are no urls, fall back to the remote name as a url" code.

-Peff