Re: [PATCH] chainlint.pl: recognize test bodies defined via heredoc
- From
Jeff King <peff@peff.net>
- Date
- Jul 10, 2024, 00:37 UTC
- Message-ID
- <20240710003737.GA1526498@coredump.intra.peff.net>
- In-Reply-To
- <CAPig+cTUsLHnCKcVMGTGUFXX85bDgMOAuvb6uXmDqpB3XswHcQ@mail.gmail.com>
On Mon, Jul 08, 2024 at 04:17:46PM -0400, Eric Sunshine wrote:
Show 6 quoted lines
> By the way, regarding your 4s instead of 200ms result, I don't think > that is necessarily reflective of what can be achieved. In particular, > to properly measure the effect, you also need to remove all the > threading support from chainlint.pl since using "ithreads" adds a > not-insignificant amount of time to script startup, especially on > Windows, but even on Unix it is quite noticeable.
Yes, that is the low-hanging fruit I found. ;) Just adding:
$jobs = @scripts if @scripts < $jobs;
cuts the time to run all scripts individually from ~4s to ~1.7s.
Removing the threading entirely goes to ~1.1s. I hadn't tried that until now, but it is probably worth doing for the case of $jobs == 1.
-Peff