Re: [PATCH v4 11/24] pseudo-merge: implement support for selecting pseudo-merge commits

From: Jeff King <peff@peff.net>
Date: May 25, 2024, 03:22 UTC
Message-ID: <20240525032229.GA1890223@coredump.intra.peff.net>
In-Reply-To: <180072ce84868265acfda8c1adf375e39a3b7610.1716499565.git.me@ttaylorr.com>

On Thu, May 23, 2024 at 05:26:42PM -0400, Taylor Blau wrote:

Show 5 quoted lines

> +static uint32_t pseudo_merge_group_size(const struct pseudo_merge_group *group,
> +					const struct pseudo_merge_matches *matches,
> +					uint32_t i)
> +{
> +	double C = 0.0f;

This version mostly drops the "f" from floating point constants, since they're now doubles. But this one doesn't.

I don't think it really matters in practice (the number obviously fits in a float, and then it ends up as a double in the variable), so it's really just a style / readability question.

Not worth a re-roll IMHO.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.