[PATCH 10/11] userdiff: use git_config_string_dup() when we can
- From
Jeff King <peff@peff.net>
- Date
- Apr 7, 2024, 01:04 UTC
- Message-ID
- <20240407010450.GJ868358@coredump.intra.peff.net>
- In-Reply-To
- <20240407005656.GA436890@coredump.intra.peff.net>
There are many uses of git_config_string() in the userdiff code which have the usual "leak when we see the variable multiple times" problem. We can fix many of these in the usual way by switching to the _dup() variant.
But note there are some adjacent ones we cannot fix right now: funcname patterns and word regexes default to string literals, and we can't use those with our dup variant (which would try to free the literals). For now let's convert what we can.
Signed-off-by: Jeff King <peff@peff.net> --- userdiff.c | 6 +++--- userdiff.h | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/userdiff.c b/userdiff.c index 92ef649c99..ba168f50b5 100644 --- a/userdiff.c +++ b/userdiff.c @@ -409,15 +409,15 @@ int userdiff_config(const char *k, const char *v) if (!strcmp(type, "binary")) return parse_tristate(&drv->binary, k, v); if (!strcmp(type, "command")) - return git_config_string(&drv->external, k, v); + return git_config_string_dup(&drv->external, k, v); if (!strcmp(type, "textconv")) - return git_config_string(&drv->textconv, k, v); + return git_config_string_dup(&drv->textconv, k, v); if (!strcmp(type, "cachetextconv")) return parse_bool(&drv->textconv_want_cache, k, v); if (!strcmp(type, "wordregex")) return git_config_string(&drv->word_regex, k, v); if (!strcmp(type, "algorithm")) - return git_config_string(&drv->algorithm, k, v); + return git_config_string_dup(&drv->algorithm, k, v); return 0; } diff --git a/userdiff.h b/userdiff.h index d726804c3e..7cae1f4da0 100644 --- a/userdiff.h +++ b/userdiff.h @@ -13,13 +13,13 @@ struct userdiff_funcname { struct userdiff_driver { const char *name; - const char *external; - const char *algorithm; + char *external; + char *algorithm; int binary; struct userdiff_funcname funcname; const char *word_regex; const char *word_regex_multi_byte; - const char *textconv; + char *textconv; struct notes_cache *textconv_cache; int textconv_want_cache; };
-- 2.44.0.872.g288abe5b5b