git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] path: remove mksnpath()

From
Jeff King <peff@peff.net>
Date
Apr 5, 2024, 17:37 UTC
Message-ID
<20240405173718.GB2529133@coredump.intra.peff.net>
In-Reply-To
<c085abab-2f10-488d-87d4-65e92e0ea24b@web.de>
On Fri, Apr 05, 2024 at 12:56:48PM +0200, René Scharfe wrote:
Show 7 quoted lines
> Remove the function mksnpath(), which has become unused.
> 
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
> Changes since v1:
> - Split out removal of mksnpath() into a separate patch, this one.
> - Remove occurrence in contrib/vscode/init.sh as well.

Thanks, both patches (including the errno handling in the first one) look good to me. I'd probably have waxed philosophical about why mksnpath() is a bad interface in this one, but I think it's OK to skip that. ;)

-Peff
Previous: René ScharfeNext: Junio C Hamano
Message 14 of 15 in “apply: replace mksnpath() with a mkpathdup() call”
  1. apply: replace mksnpath() with a mkpathdup() callRené Scharfe, Apr 4, 2024
  2. Junio C HamanoApr 4, 2024
  3. free and errno, was Re: [PATCH] apply: replace mksnpath() with a mkpathdup() callJeff King, Apr 4, 2024
  4. Junio C HamanoApr 4, 2024
  5. René ScharfeApr 5, 2024
  6. Jeff KingApr 5, 2024
  7. Jeff KingApr 5, 2024
  8. René ScharfeApr 6, 2024
  9. Jeff KingApr 7, 2024
  10. René ScharfeApr 14, 2024
  11. Jeff KingApr 24, 2024
  12. 1/2 apply: avoid fixed-size buffer in create_one_file()René Scharfe, Apr 5, 2024
  13. 2/2 path: remove mksnpath()René Scharfe, Apr 5, 2024
  14. Jeff KingApr 5, 2024
  15. Junio C HamanoApr 5, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.