From: Jeff King Date: Fri, 05 Apr 2024 17:37:18 GMT Subject: Re: [PATCH v2 2/2] path: remove mksnpath() Message-ID: <20240405173718.GB2529133@coredump.intra.peff.net> In-Reply-To: On Fri, Apr 05, 2024 at 12:56:48PM +0200, René Scharfe wrote: > Remove the function mksnpath(), which has become unused. > > Signed-off-by: René Scharfe > --- > Changes since v1: > - Split out removal of mksnpath() into a separate patch, this one. > - Remove occurrence in contrib/vscode/init.sh as well. Thanks, both patches (including the errno handling in the first one) look good to me. I'd probably have waxed philosophical about why mksnpath() is a bad interface in this one, but I think it's OK to skip that. ;) -Peff