git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 0/3] commit, add: error out when passing untracked paths

From
Ghanshyam Thakkar <shyamthakkar001@gmail.com>
Date
Apr 2, 2024, 21:36 UTC
Message-ID
<20240402213640.139682-2-shyamthakkar001@gmail.com>
In-Reply-To
<20240329205649.1483032-2-shyamthakkar001@gmail.com>

This version uses Junio's patch ,which adds a new .ps_matched member to 'strcut rev_info' to record the pathspec elements that matched tracked paths, as base for patch [2/3] and [3/3].

Patch [2/3] remains unchanged from v2. And patch [3/3] is updated according to Junio's suggestions.

Ghanshyam Thakkar (2):
  builtin/commit: error out when passing untracked path with -i
  builtin/add: error out when passing untracked path with -u
Junio C Hamano (1):
  revision: optionally record matches with pathspec elements
 builtin/add.c                         | 13 +++++++++++--
 builtin/checkout.c                    |  3 ++-
 builtin/commit.c                      |  9 ++++++++-
 diff-lib.c                            | 11 ++++++++++-
 read-cache-ll.h                       |  4 ++--
 read-cache.c                          |  8 +++++---
 revision.h                            |  1 +
 t/t2200-add-update.sh                 | 10 ++++++++++
 t/t7501-commit-basic-functionality.sh | 16 +---------------
 9 files changed, 50 insertions(+), 25 deletions(-)
-- 
2.44.0
Previous: Ghanshyam ThakkarNext: Ghanshyam Thakkar
Message 7 of 31 in “fix certain cases of add and commit with untracked path not erroring out”
  1. 0/2 fix certain cases of add and commit with untracked path not erroring outGhanshyam Thakkar, Mar 18, 2024
  2. 1/2 builtin/commit: error out when passing untracked path with -iGhanshyam Thakkar, Mar 18, 2024
  3. Junio C HamanoMar 18, 2024
  4. 2/2 builtin/add: error out when passing untracked path with -uGhanshyam Thakkar, Mar 18, 2024
  5. Junio C HamanoMar 18, 2024
  6. 0/3 commit, add: error out when passing untracked pathGhanshyam Thakkar, Mar 29, 2024
  7. 0/3 commit, add: error out when passing untracked pathsGhanshyam Thakkar, Apr 2, 2024
  8. 0/3 commit,add: error out when passing untracked pathGhanshyam Thakkar, Apr 3, 2024
  9. 1/3 revision: optionally record matches with pathspec elementsGhanshyam Thakkar, Apr 3, 2024
  10. 2/3 builtin/commit: error out when passing untracked path with -iGhanshyam Thakkar, Apr 3, 2024
  11. 3/3 builtin/add: error out when passing untracked path with -uGhanshyam Thakkar, Apr 3, 2024
  12. 1/3 revision: optionally record matches with pathspec elementsGhanshyam Thakkar, Apr 2, 2024
  13. 2/3 builtin/commit: error out when passing untracked path with -iGhanshyam Thakkar, Apr 2, 2024
  14. Junio C HamanoApr 2, 2024
  15. Ghanshyam ThakkarApr 2, 2024
  16. 3/3 builtin/add: error out when passing untracked path with -uGhanshyam Thakkar, Apr 2, 2024
  17. Junio C HamanoApr 2, 2024
  18. Ghanshyam ThakkarApr 2, 2024
  19. 1/3 read-cache: optionally collect pathspec matching infoGhanshyam Thakkar, Mar 29, 2024
  20. Junio C HamanoMar 29, 2024
  21. Junio C HamanoMar 29, 2024
  22. Ghanshyam ThakkarMar 30, 2024
  23. Junio C HamanoMar 30, 2024
  24. 2/3 builtin/commit: error out when passing untracked path with -iGhanshyam Thakkar, Mar 29, 2024
  25. Junio C HamanoMar 29, 2024
  26. 3/3 builtin/add: error out when passing untracked path with -uGhanshyam Thakkar, Mar 29, 2024
  27. Junio C HamanoMar 29, 2024
  28. Ghanshyam ThakkarMar 30, 2024
  29. Junio C HamanoMar 30, 2024
  30. Ghanshyam ThakkarApr 1, 2024
  31. Junio C HamanoApr 1, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.