[PATCH v2 2/2] t0024: style fix
- From
Ghanshyam Thakkar <shyamthakkar001@gmail.com>
- Date
- Jan 19, 2024, 01:36 UTC
- Message-ID
- <20240119013745.2476045-2-shyamthakkar001@gmail.com>
- In-Reply-To
- <20240119013745.2476045-1-shyamthakkar001@gmail.com>
t0024 has multiple command invocations on a single line, which goes against the style described in CodingGuidelines, thus fix that.
Also, use the -C flag to give the destination when using $TAR, therefore, not requiring a subshell.
Signed-off-by: Ghanshyam Thakkar <shyamthakkar001@gmail.com> --- t/t0024-crlf-archive.sh | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/t/t0024-crlf-archive.sh b/t/t0024-crlf-archive.sh index fa4da7c2b3..9967a646d1 100755 --- a/t/t0024-crlf-archive.sh +++ b/t/t0024-crlf-archive.sh @@ -20,7 +20,8 @@ test_expect_success setup ' test_expect_success 'tar archive' ' git archive --format=tar HEAD >test.tar && - ( mkdir untarred && cd untarred && "$TAR" -xf ../test.tar ) && + mkdir untarred && + "$TAR" Cxf untarred test.tar && test_cmp sample untarred/sample @@ -30,7 +31,11 @@ test_expect_success UNZIP 'zip archive' ' git archive --format=zip HEAD >test.zip && - ( mkdir unzipped && cd unzipped && "$GIT_UNZIP" ../test.zip ) && + mkdir unzipped && + ( + cd unzipped && + "$GIT_UNZIP" ../test.zip + ) && test_cmp sample unzipped/sample
-- 2.43.0