git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] t0024: refactor to have single command per line

From
Ghanshyam Thakkar <shyamthakkar001@gmail.com>
Date
Jan 18, 2024, 21:53 UTC
Message-ID
<20240118215407.8609-2-shyamthakkar001@gmail.com>
In-Reply-To
<20240118215407.8609-1-shyamthakkar001@gmail.com>

Refactor t0024 to avoid having multiple chaining commands on a single line, according to current styling norms.

e.g turn
    ( mkdir testdir && cd testdir && echo "in testdir" )
into:
    mkdir testdir &&
    (
        cd testdir &&
        echo "in testdir"
    )
This is also described in the Documentation/CodingGuidelines file.
Signed-off-by: Ghanshyam Thakkar <shyamthakkar001@gmail.com>
---
 t/t0024-crlf-archive.sh | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/t/t0024-crlf-archive.sh b/t/t0024-crlf-archive.sh
index fa4da7c2b3..ff4efeaaee 100755
--- a/t/t0024-crlf-archive.sh
+++ b/t/t0024-crlf-archive.sh
@@ -20,7 +20,11 @@ test_expect_success setup '
 test_expect_success 'tar archive' '
 
 	git archive --format=tar HEAD >test.tar &&
-	( mkdir untarred && cd untarred && "$TAR" -xf ../test.tar ) &&
+	mkdir untarred &&
+	(
+		cd untarred &&
+		"$TAR" -xf ../test.tar
+	) &&
 
 	test_cmp sample untarred/sample
 
@@ -30,7 +34,11 @@ test_expect_success UNZIP 'zip archive' '
 
 	git archive --format=zip HEAD >test.zip &&
 
-	( mkdir unzipped && cd unzipped && "$GIT_UNZIP" ../test.zip ) &&
+	mkdir unzipped &&
+	(
+		cd unzipped &&
+		"$GIT_UNZIP" ../test.zip
+	) &&
 
 	test_cmp sample unzipped/sample
 
-- 
2.43.0
Previous: Ghanshyam ThakkarNext: Junio C Hamano
Message 2 of 10 in “t0024: avoid losing exit status to pipes”
  1. 1/2 t0024: avoid losing exit status to pipesGhanshyam Thakkar, Jan 18, 2024
  2. 2/2 t0024: refactor to have single command per lineGhanshyam Thakkar, Jan 18, 2024
  3. Junio C HamanoJan 18, 2024
  4. Ghanshyam ThakkarJan 19, 2024
  5. Ghanshyam ThakkarJan 19, 2024
  6. Junio C HamanoJan 18, 2024
  7. 1/2 t0024: avoid losing exit status to pipesGhanshyam Thakkar, Jan 19, 2024
  8. 2/2 t0024: style fixGhanshyam Thakkar, Jan 19, 2024
  9. 1/2 t0024: avoid losing exit status to pipesGhanshyam Thakkar, Jan 19, 2024
  10. 2/2 t0024: style fixGhanshyam Thakkar, Jan 19, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.