Re: Request for Help - Too many perl arguments as of 2.43.0-rc0

From: Jeff King <peff@peff.net>
Date: Nov 5, 2023, 05:34 UTC
Message-ID: <20231105051615.GA1515359@coredump.intra.peff.net>
In-Reply-To: <CAPig+cTy7Mq1xhTtssoUDpwrCNB_65q4VjK902jOpJ4469_tLw@mail.gmail.com>

On Sat, Nov 04, 2023 at 08:11:01PM -0400, Eric Sunshine wrote:

Show 11 quoted lines

> > Hmm. With compilation, we split the audience of "developers" vs "people
> > who just want to build the program", and we crank up the number and
> > severity of warning checks for the former. We could do the same here for
> > tests. I.e., turn off test linting by default and re-enable it for
> > DEVELOPER=1.
> 
> My knee-jerk reaction is that this would move us in the wrong
> direction since it is probable that most drive-by contributors won't
> have DEVELOPER=1 set, yet they are the ones who are likely to benefit
> most from test script linting (which is not to say that it doesn't
> help seasoned contributors, as well).

Yeah, that's a good point. If the linting is not causing frequent headaches (and I don't think it is), then we are better to leave it on by default.

-Peff