Re: Request for Help - Too many perl arguments as of 2.43.0-rc0

From: Jeff King <peff@peff.net>
Date: Nov 4, 2023, 13:49 UTC
Message-ID: <20231104134915.GA1492953@coredump.intra.peff.net>
In-Reply-To: <CAPig+cQpxRQnhffR8EWWRhqJPmOeOuCE3qsuMcnDyuMLLbTH8Q@mail.gmail.com>

On Sat, Nov 04, 2023 at 02:36:48AM -0400, Eric Sunshine wrote:

Show 7 quoted lines

> I don't see an urgent need for it. Unlike the actual tests themselves
> run by `make test` which may catch platform-specific problems in Git
> itself, the purpose of the "linting" checks is not to catch
> platform-specific problems, but rather to help test authors by
> identifying mistakes in the tests which might make them fragile. So,
> disabling linting on a particular platform isn't going to cause `make
> test` to miss some important Git problem specific to that platform.

Hmm. With compilation, we split the audience of "developers" vs "people who just want to build the program", and we crank up the number and severity of warning checks for the former. We could do the same here for tests. I.e., turn off test linting by default and re-enable it for DEVELOPER=1.

OTOH, this is the first time I think I've seen the linting cause a problem (whereas unexpected compile warnings are much more likely, as we are depending on the system compiler's behavior).

So consider it an idle thought for discussion, and not necessarily a proposal. ;)

-Peff