Re: [PATCH 3/5] git-jump: admit to passing merge mode args to ls-files

From: Štěpán Němec <stepnem@smrk.net>
Date: Oct 3, 2023, 20:15 UTC
Message-ID: <20231003221537+0200.850949-stepnem@smrk.net>
In-Reply-To: <CAPig+cQHAK2_LEG0-6MTF52t2D8b_SRxzB51B_4N35ujtGeb6Q@mail.gmail.com>

On Tue, 3 Oct 2023 14:33:39 -0400 Eric Sunshine wrote:

Show 16 quoted lines

> On Tue, Oct 3, 2023 at 4:28 AM Štěpán Němec <stepnem@smrk.net> wrote:
>> There's even an example of such usage in the README.
>>
>> Signed-off-by: Štěpán Němec <stepnem@smrk.net>
>> ---
>> diff --git a/contrib/git-jump/git-jump b/contrib/git-jump/git-jump
>> @@ -9,7 +9,7 @@ The <mode> parameter is one of:
>>
>>  diff: elements are diff hunks. Arguments are given to diff.
>>
>> -merge: elements are merge conflicts. Arguments are ignored.
>> +merge: elements are merge conflicts. Arguments are given to ls-files -u.
>
> Should "ls-files -u" be formatted with backticks?
>
>     Arguments are passed to `git ls-files -u`.

My preference is against this (I don't like markup in plain-text files), although, unlike the contrib README case in 1/5, here there _are_ some pre-existing backquotes; but the usage is inconsistent. If we want to unify one way or the other, I'd leave that for another patch, in any case.

Thanks,

  Štěpán