[PATCH 08/10] commit-graph: free write-context entries before overwriting
- From
Jeff King <peff@peff.net>
- Date
- Oct 3, 2023, 20:30 UTC
- Message-ID
- <20231003203055.GH7812@coredump.intra.peff.net>
- In-Reply-To
- <20231003202504.GA7697@coredump.intra.peff.net>
When writing a split graph file, we replace the final element of the commit_graph_hash_after and commit_graph_filenames_after arrays. But since these are allocated strings, we need to free them before overwriting to avoid leaking the old string.
Signed-off-by: Jeff King <peff@peff.net> --- commit-graph.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/commit-graph.c b/commit-graph.c index 4aa2f294f1..744b7eb1a3 100644 --- a/commit-graph.c +++ b/commit-graph.c @@ -2065,9 +2065,11 @@ static int write_commit_graph_file(struct write_commit_graph_context *ctx) free(graph_name); } + free(ctx->commit_graph_hash_after[ctx->num_commit_graphs_after - 1]); ctx->commit_graph_hash_after[ctx->num_commit_graphs_after - 1] = xstrdup(hash_to_hex(file_hash)); final_graph_name = get_split_graph_filename(ctx->odb, ctx->commit_graph_hash_after[ctx->num_commit_graphs_after - 1]); + free(ctx->commit_graph_filenames_after[ctx->num_commit_graphs_after - 1]); ctx->commit_graph_filenames_after[ctx->num_commit_graphs_after - 1] = final_graph_name; result = rename(ctx->graph_name, final_graph_name);
-- 2.42.0.810.gbc538a0ee6