Re: [PATCH v1 1/1] git stash needing mkdir deletes untracked file

From: Torsten Bögershausen <tboegi@web.de>
Date: Aug 9, 2023, 18:47 UTC
Message-ID: <20230809184751.ffwolkvjwoptnmen@tb-raspi4>
In-Reply-To: <6e40eb0b-2331-1e39-bee0-c9720c24d1c8@gmail.com>

On Wed, Aug 09, 2023 at 02:15:28PM +0100, Phillip Wood wrote:

> Hi Torsten
>
> Thanks for working on this. I've cc'd Junio for his unpack_trees()
> knowledge.

Thanks Eric for the review.

Hej Phillip, I have been playing around with the whole thing some time. At the end I had a version, which did fiddle the information that we are doing a `git stash` (and not any other operation) into entry.c, and all test cases passed. So in principle I can dig out all changes, polish them and send them out, after doing cleanups of course.

(And that could take a couple of days, or weeks ;-)

My main question is still open: Is it a good idea, to create a "helper file" ? The naming can be discussed, we may stick the date/time into the filename to make it really unique, or so.

Reading the different reports and including own experience, I still think that a directory called ".deleted-by-user" or ".wastebin" or something in that style is a good idea.

What do others think ?