git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/3] configure.ac: always save NO_ICONV to config.status

From
AHAndreas Herrmann <aherrmann@suse.de>
Date
Jul 19, 2023, 14:29 UTC
Message-ID
<20230719145211.17854-8-aherrmann@suse.de>
In-Reply-To
<20230719145211.17854-2-aherrmann@suse.de>

In case 'configure --with-iconv=no' is used, NO_ICONV is not saved to config.status and thus git is built with iconv support.

Always save NO_ICONV to config.status to honor what user selected during configure step.

Signed-off-by: Andreas Herrmann <aherrmann@suse.de>
---
 configure.ac | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index e85e215f14..276593cd9d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -644,7 +644,6 @@ LIBS="$old_LIBS"
 GIT_UNSTASH_FLAGS($ICONVDIR)
 
 GIT_CONF_SUBST([NEEDS_LIBICONV])
-GIT_CONF_SUBST([NO_ICONV])
 
 if test -n "$NO_ICONV"; then
     NEEDS_LIBICONV=
@@ -652,6 +651,8 @@ fi
 
 fi
 
+GIT_CONF_SUBST([NO_ICONV])
+
 #
 # Define NO_DEFLATE_BOUND if deflateBound is missing from zlib.
 
-- 
2.41.0
Previous: Andreas HerrmannNext: Junio C Hamano
Message 4 of 5 in “configure.ac: misc configure fixes”
  1. 0/3 configure.ac: misc configure fixesAndreas Herrmann, Jul 19, 2023
  2. 1/3 configure.ac: don't overwrite NO_EXPAT optionAndreas Herrmann, Jul 19, 2023
  3. 2/3 configure.ac: don't overwrite NO_CURL optionAndreas Herrmann, Jul 19, 2023
  4. 3/3 configure.ac: always save NO_ICONV to config.statusAndreas Herrmann, Jul 19, 2023
  5. Junio C HamanoJul 19, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.