git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/3] configure.ac: don't overwrite NO_CURL option

From
AHAndreas Herrmann <aherrmann@suse.de>
Date
Jul 19, 2023, 14:29 UTC
Message-ID
<20230719145211.17854-6-aherrmann@suse.de>
In-Reply-To
<20230719145211.17854-2-aherrmann@suse.de>

Even if 'configure --with-curl=no' was run, curl support is used, because library detection overwrites it. Avoid this overwrite. Configure should obey what the user has specified.

Signed-off-by: Andreas Herrmann <aherrmann@suse.de>
---
 configure.ac | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/configure.ac b/configure.ac
index 62cc8197f8..e85e215f14 100644
--- a/configure.ac
+++ b/configure.ac
@@ -546,6 +546,8 @@ fi
 # git-http-push are not built, and you cannot use http:// and https://
 # transports.
 
+if test -z "$NO_CURL"; then
+
 GIT_STASH_FLAGS($CURLDIR)
 
 AC_CHECK_LIB([curl], [curl_global_init],
@@ -554,6 +556,8 @@ AC_CHECK_LIB([curl], [curl_global_init],
 
 GIT_UNSTASH_FLAGS($CURLDIR)
 
+fi
+
 GIT_CONF_SUBST([NO_CURL])
 
 if test -z "$NO_CURL"; then
-- 
2.41.0
Previous: Andreas HerrmannNext: Andreas Herrmann
Message 3 of 5 in “configure.ac: misc configure fixes”
  1. 0/3 configure.ac: misc configure fixesAndreas Herrmann, Jul 19, 2023
  2. 1/3 configure.ac: don't overwrite NO_EXPAT optionAndreas Herrmann, Jul 19, 2023
  3. 2/3 configure.ac: don't overwrite NO_CURL optionAndreas Herrmann, Jul 19, 2023
  4. 3/3 configure.ac: always save NO_ICONV to config.statusAndreas Herrmann, Jul 19, 2023
  5. Junio C HamanoJul 19, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.