Re: [PATCH v2 11/14] config: pass kvi to die_bad_number()

From: Jonathan Tan <jonathantanmy@google.com>
Date: Jun 1, 2023, 23:48 UTC
Message-ID: <20230601234829.432150-1-jonathantanmy@google.com>
In-Reply-To: <504eb206b5a1ac12676752d68b2e2569dc6737ef.1685472134.git.gitgitgadget@gmail.com>

"Glen Choo via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 8 quoted lines

> Outside of config.c, config callbacks now need to pass "kvi" to any of
> the git_config_<type>() functions that parse a config string into a
> number type. Included is a .cocci patch to make that refactor. In cases
> where "kvi" would never be used, pass NULL, e.g.:
> 
> - In config.c, when we are parsing a boolean instead of a number
> - In builtin/config.c, when calling normalize_value() before setting
>   config to something the user gave us.

In these cases, could we synthesize a kvi instead of using NULL? I believe there are already code paths that use an UNKNOWN scope - these seem similar to that.

Otherwise looks good - a straightforward, mostly mechanical, change.